sor 3.16.24 #370
Merged
sor 3.16.24 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeki
approved these changes
Sep 15, 2023
jsy1218
added a commit
that referenced
this pull request
Sep 15, 2023
* sor 3.16.24 * fix compiling error due to sor upgrade related to fot tax * prettier
jsy1218
added a commit
that referenced
this pull request
Sep 15, 2023
* sor 3.16.24 * fix compiling error due to sor upgrade related to fot tax * prettier
jsy1218
added a commit
that referenced
this pull request
Sep 15, 2023
* rebase main merge conflcit * routing-api side of changes to support fot * prettier * fix lock file * disable cached routes reads under feature flag, but always enable writing into the routes DB * bump sor to 3.16.23 * Try catch container injected (#363) * Try catch container injected * lint * rebase * routing-api side of changes to support fot * fix lock file * bump sor to 3.16.23 * use string for buyFeeBps and sellFeeBps * address feedbacks other than integ-test * merge conflict * prettier * integ-test for fot * quote fot test so far * add fot integ-test init * add integ-test for bullet -> weth swaps * prettier * final changes in ra * complete test assertions * prettier * fix useCachedRoutes not override to false when enableFeeOnTransferFeeFetching is true * prettier * sor 3.16.24 (#370) * sor 3.16.24 * fix compiling error due to sor upgrade related to fot tax * prettier * prettier * feedback * bump sor to 3.16.25 to include the quote-provider potential fot double tax bug * prettier --------- Co-authored-by: Miguel Cervera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Uniswap/smart-order-router#400
Also due to Uniswap/smart-order-router#397, which releases Uniswap/smart-order-router#394, we have a compiling error in
V2DynamoCache. NotebatchGetis not being called anywhere today in prod.